Add screen reader mode support, deprecate keyboard controls toggle#15
Draft
microbit-matt-hillsdon wants to merge 1 commit into
Draft
Add screen reader mode support, deprecate keyboard controls toggle#15microbit-matt-hillsdon wants to merge 1 commit into
microbit-matt-hillsdon wants to merge 1 commit into
Conversation
Adds MakeCodeFrameDriver.toggleScreenReaderMode() sending the new "togglescreenreadermode" action and an optional screenReaderMode field on the info response, both supported by the next MakeCode release. toggleKeyboardControls() remains for API compatibility but is deprecated as current MakeCode versions keep keyboard controls always enabled, so it does nothing. The storybook toolbar button now exercises the screen reader toggle, and the editor stories' version control gains a "local" option pointing at a locally running pxt-microbit dev server for testing unreleased editor changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds MakeCodeFrameDriver.toggleScreenReaderMode() sending the new "togglescreenreadermode" action and an optional screenReaderMode field on the info response, both supported by the next MakeCode release. toggleKeyboardControls() remains for API compatibility but is deprecated as current MakeCode versions keep keyboard controls always enabled, so it does nothing.
The storybook toolbar button now exercises the screen reader toggle, and the editor stories' version control gains a "local" option pointing at a locally running pxt-microbit dev server for testing unreleased editor changes.
Depends on microsoft/pxt#11459
Draft until MakeCode release with that change.
I've tested this locally with the above pxt PR.